S3 Code Rewrite #1958
Merged
S3 Code Rewrite #1958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviesrob
reviewed
Oct 3, 2025
daviesrob
reviewed
Oct 7, 2025
daviesrob
reviewed
Nov 6, 2025
Add code to read from S3 sources in the same style as the current writing code. Merge the s3_write.c code into hfile_s3.c to put all the S3 code in the same file. This should simplify the S3 code and give us a little more flexibility in how we use it.
daviesrob
reviewed
Nov 11, 2025
daviesrob
reviewed
Nov 13, 2025
daviesrob
reviewed
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add code to read from S3 sources in the same style as the current writing code. Merge the s3_write.c code into hfile_s3.c to put all the S3 code in the same file.
This should simplify the S3 code and give us a little more flexibility in how we use it.
Still need to remove the old writing code (file removal and other modifications).